db/proxy: allocate Directory instance on the stack

83a988e2 · Max Kellermann · 91efe1cb · 83a988e2
Commit 83a988e2 authored Jan 09, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 7 deletions

ProxyDatabasePlugin.cxx src/db/ProxyDatabasePlugin.cxx +3 -7

No files found.
--- a/src/db/ProxyDatabasePlugin.cxx
+++ b/src/db/ProxyDatabasePlugin.cxx
@@ -360,13 +360,9 @@ Visit(struct mpd_connection *connection, Directory &root,
 {
 	const char *path = mpd_directory_get_path(directory);
-	if (visit_directory) {
+	if (visit_directory &&
-		Directory *d = Directory::NewGeneric(path, &root);
+	    !visit_directory(Directory(path, &root), error))
-		bool success = visit_directory(*d, error);
+		return false;
-		d->Free();
-		if (!success)
-			return false;
-	}
 	if (recursive &&
 	    !Visit(connection, root, path, recursive, filter,