decoder_internal: don't push empty chunk into pipe

When the decoder chunk is empty in decoder_flush_chunk(), don't push it into the music pipe - return it to the music buffer instead. An empty chunk in the pipe wastes resources for no advantage.

decoder_internal: don't push empty chunk into pipe
85cc46ad · Max Kellermann · eb2e3a55 · 85cc46ad
Commit 85cc46ad authored Mar 07, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

decoder_internal.c src/decoder_internal.c +6 -1

No files found.
--- a/src/decoder_internal.c
+++ b/src/decoder_internal.c
@@ -22,6 +22,7 @@
 #include "pipe.h"
 #include "input_stream.h"
 #include "buffer.h"
+#include "chunk.h"

 #include <assert.h>

@@ -73,6 +74,10 @@ decoder_flush_chunk(struct decoder *decoder)
 	assert(decoder != NULL);
 	assert(decoder->chunk != NULL);

-	music_pipe_push(dc.pipe, decoder->chunk);
+	if (music_chunk_is_empty(decoder->chunk))
+		music_buffer_return(dc.buffer, decoder->chunk);
+	else
+		music_pipe_push(dc.pipe, decoder->chunk);
+
 	decoder->chunk = NULL;
 }