decoder: introduce switch statement in decoder_task()

switch looks much nicer than if/elseif/... and gcc generates nice warnings when a new command is added to the enum.

decoder: introduce switch statement in decoder_task()
86fbac54 · Max Kellermann · 78448fe1 · 86fbac54
Commit 86fbac54 authored Oct 31, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 4 deletions

decoder_thread.c src/decoder_thread.c +10 -4

No files found.
--- a/src/decoder_thread.c
+++ b/src/decoder_thread.c
@@ -169,15 +169,21 @@ static void * decoder_task(mpd_unused void *arg)
 	while (1) {
 		assert(dc.state == DECODE_STATE_STOP);

-		if (dc.command == DECODE_COMMAND_START ||
-		    dc.command == DECODE_COMMAND_SEEK) {
+		switch (dc.command) {
+		case DECODE_COMMAND_START:
+		case DECODE_COMMAND_SEEK:
 			decodeStart();
-		} else if (dc.command == DECODE_COMMAND_STOP) {
+			break;
+
+		case DECODE_COMMAND_STOP:
 			dc.command = DECODE_COMMAND_NONE;
 			notify_signal(&pc.notify);
-		} else {
+			break;
+
+		case DECODE_COMMAND_NONE:
 			notify_wait(&dc.notify);
 			notify_signal(&pc.notify);
+			break;
 		}
 	}