output/alsa: improve silence generator test in DrainInternal()

src/lib/alsa/PeriodBuffer.hxx

@@ -74,6 +74,14 @@ public:
 	}
 
 	/**
+	 * Has some data already been consumed at the buffer's head in
+	 * this period?
+	 */
+	bool WasConsumed() const noexcept {
+		return head > 0;
+	}
+
+	/**
 	 * Returns the tail of the buffer, i.e. where new data can be
 	 * written.  Call GetSpaceBytes() to find out how much may be
 	 * copied to the returned pointer, and call AppendBytes() to
@@ -163,10 +171,6 @@ public:
 		ConsumeBytes(n * frame_size);
 	}
 
-	snd_pcm_uframes_t GetPeriodPosition(size_t frame_size) const noexcept {
-		return head / frame_size;
-	}
-
 	void Rewind() noexcept {
 		head = 0;
 	}

src/output/plugins/AlsaOutputPlugin.cxx

@@ -746,8 +746,7 @@ AlsaOutput::DrainInternal()
 	/* drain ring_buffer */
 	CopyRingToPeriodBuffer();
 
-	auto period_position = period_buffer.GetPeriodPosition(out_frame_size);
-	if (period_position > 0)
+	if (period_buffer.WasConsumed())
 		/* generate some silence to finish the partial
 		   period */
 		period_buffer.FillWithSilence(silence, out_frame_size);