tag/Builder: use std::swap() in move operator

This way, we save the overhead for acquiring the tag_pool_lock.

tag/Builder: use std::swap() in move operator
96875921 · Max Kellermann · 551c941b · 96875921
Commit 96875921 authored Aug 05, 2021 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

Builder.cxx src/tag/Builder.cxx +5 -2

No files found.
--- a/src/tag/Builder.cxx
+++ b/src/tag/Builder.cxx
@@ -78,11 +78,14 @@ TagBuilder::operator=(const TagBuilder &other) noexcept
 TagBuilder &
 TagBuilder::operator=(TagBuilder &&other) noexcept
 {
+	using std::swap;
+
 	duration = other.duration;
 	has_playlist = other.has_playlist;

-	RemoveAll();
-	items = std::move(other.items);
+	/* swap the two TagItem lists so we don't need to touch the
+	   tag pool just yet */
+	swap(items, other.items);

 	return *this;
 }