filter/convert: fix no-op check

Commit 3a212412 changed the meaning of out_audio_format, but I forgot to apply this to ConvertFilter::FilterPCM(). See https://bugs.musicpd.org/view.php?id=4551

filter/convert: fix no-op check
a012b253 · Max Kellermann · 46e8b137 · a012b253
Commit a012b253 authored Jul 04, 2016 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

ConvertFilterPlugin.cxx src/filter/plugins/ConvertFilterPlugin.cxx +2 -2

No files found.
--- a/src/filter/plugins/ConvertFilterPlugin.cxx
+++ b/src/filter/plugins/ConvertFilterPlugin.cxx
@@ -110,7 +110,7 @@ ConvertFilter::~ConvertFilter()
 {
 	assert(in_audio_format.IsValid());

-	if (out_audio_format.IsValid())
+	if (out_audio_format != in_audio_format)
 		state.Close();
 }

@@ -119,7 +119,7 @@ ConvertFilter::FilterPCM(ConstBuffer<void> src, Error &error)
 {
 	assert(in_audio_format.IsValid());

-	if (!out_audio_format.IsValid())
+	if (out_audio_format == in_audio_format)
 		/* optimized special case: no-op */
 		return src;