tag/TagPool: optimize _dup_item()

When a reference counter is at its limit, don't allocate a new TagPoolSlot - that would result in many TagPoolSlot instances with ref==1. This in turn would make the linked list very very large, which means quadratic runtime for many operations.

tag/TagPool: optimize _dup_item()
a3afd517 · Max Kellermann · f1285a6d · a3afd517 · a3afd517
Commit a3afd517 authored Mar 14, 2016 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 7 deletions

NEWS NEWS +1 -0

TagPool.cxx src/tag/TagPool.cxx +3 -7

No files found.
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,7 @@ ver 0.19.14 (not yet released)
  - opus: limit tag size to 64 kB
 * archive
  - iso9660: fix buffer overflow
+* fix quadratic runtime bug in the tag pool
 * fix build failures on non-glibc builds due to constexpr Mutex

 ver 0.19.13 (2016/02/23)

--- a/src/tag/TagPool.cxx
+++ b/src/tag/TagPool.cxx
@@ -144,14 +144,10 @@ tag_pool_dup_item(TagItem *item)
 		return item;
 	} else {
 		/* the reference counter overflows above MAX_REF;
-		   duplicate the item, and start with 1 */
+		   obtain a reference to a different TagPoolSlot which
+		   isn't yet "full" */
 		size_t length = strlen(item->value);
-		auto slot_p = tag_value_slot_p(item->type,
-					       item->value, length);
-		slot = TagPoolSlot::Create(*slot_p, item->type,
-					   item->value, strlen(item->value));
-		*slot_p = slot;
-		return &slot->item;
+		return tag_pool_get_item(item->type, item->value, length);
 	}
 }