[clang-tidy] use forward instead of move

Found with bugprone-move-forwarding-reference Signed-off-by: 's avatarRosen Penev <rosenp@gmail.com>
parent 140d8547
...@@ -50,7 +50,7 @@ template<typename T> ...@@ -50,7 +50,7 @@ template<typename T>
static auto static auto
Append(std::forward_list<T> &list, T &&src) Append(std::forward_list<T> &list, T &&src)
{ {
return list.emplace_after(FindLast(list), std::move(src)); return list.emplace_after(FindLast(list), std::forward<T>(src));
} }
void void
......
...@@ -167,7 +167,7 @@ ParseObjects(ODBus::ReadMessageIter &&i, ...@@ -167,7 +167,7 @@ ParseObjects(ODBus::ReadMessageIter &&i,
ForEachInterface(std::move(i), [&callback](const char *path, auto &&j){ ForEachInterface(std::move(i), [&callback](const char *path, auto &&j){
Object o(path); Object o(path);
ParseObject(o, std::move(j)); ParseObject(o, std::forward<decltype(j)>(j));
if (o.IsValid()) if (o.IsValid())
callback(std::move(o)); callback(std::move(o));
}); });
......
...@@ -231,7 +231,7 @@ UdisksNeighborExplorer::HandleMessage(DBusConnection *, DBusMessage *message) no ...@@ -231,7 +231,7 @@ UdisksNeighborExplorer::HandleMessage(DBusConnection *, DBusMessage *message) no
dbus_message_has_signature(message, InterfacesAddedType::value)) { dbus_message_has_signature(message, InterfacesAddedType::value)) {
RecurseInterfaceDictEntry(ReadMessageIter(*message), [this](const char *path, auto &&i){ RecurseInterfaceDictEntry(ReadMessageIter(*message), [this](const char *path, auto &&i){
UDisks2::Object o(path); UDisks2::Object o(path);
UDisks2::ParseObject(o, std::move(i)); UDisks2::ParseObject(o, std::forward<decltype(i)>(i));
if (o.IsValid()) if (o.IsValid())
this->Insert(std::move(o)); this->Insert(std::move(o));
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment