protocol/ArgParser: check for invalid ranges

Catch errors like that early, before invalid ranges get passed to internal MPD subsystems.

protocol/ArgParser: check for invalid ranges
a6c10e9a · Max Kellermann · 19a46064 · a6c10e9a · a6c10e9a
Commit a6c10e9a authored Feb 15, 2021 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

NEWS NEWS +2 -0

ArgParser.cxx src/protocol/ArgParser.cxx +4 -0

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.22.5 (not yet released)
+* protocol
+  - error for malformed ranges instead of ignoring silently
 * database
  - simple: fix missing CUE sheet metadata in "addid" command
 * tags

--- a/src/protocol/ArgParser.cxx
+++ b/src/protocol/ArgParser.cxx
@@ -110,6 +110,10 @@ ParseCommandArgRange(const char *s)
 		return RangeArg::Single(range.start);
 	}

+	if (!range.IsWellFormed())
+		throw FormatProtocolError(ACK_ERROR_ARG,
+					  "Malformed range: %s", s);
+
 	return range;
 }