OutputThread: close the output plugin after filter failure

Fixes memory leak because ao_plugin_close() never gets called.

OutputThread: close the output plugin after filter failure
a7b09d3d · Max Kellermann · 8fc37681 · a7b09d3d · a7b09d3d
Commit a7b09d3d authored Oct 23, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 0 deletions

NEWS NEWS +2 -0

OutputThread.cxx src/output/OutputThread.cxx +1 -0

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.19.2 (not yet released)
+* output
+  - fix memory leak after filter initialization error
 * fix assertion failure on unsupported PCM conversion

 ver 0.19.1 (2014/10/19)

--- a/src/output/OutputThread.cxx
+++ b/src/output/OutputThread.cxx
@@ -188,6 +188,7 @@ AudioOutput::Open()
 			    name, plugin.name);

 		mutex.unlock();
+		ao_plugin_close(this);
 		CloseFilter();
 		mutex.lock();