output/Thread: wake up the player thread periodically while playing

Without this, the pipe would run empty very often, which may result in an xrun if the roundtrip to the PlayerThread and back takes too long. By waking up the PlayerThread before the pipe runs empty, we make MPD much more latency tolerant, which is a major optimization.

output/Thread: wake up the player thread periodically while playing
a9d72938 · Max Kellermann · add42e9e · a9d72938 · a9d72938
Commit a9d72938 authored Dec 13, 2016 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 12 additions and 0 deletions

NEWS NEWS +1 -0

OutputThread.cxx src/output/OutputThread.cxx +11 -0

No files found.
--- a/NEWS
+++ b/NEWS
@@ -52,6 +52,7 @@ ver 0.20 (not yet released)
  - soxr: allow multi-threaded resampling
 * player
  - reset song priority on playback
+  - reduce xruns
 * write database and state file atomically
 * always write UTF-8 to the log file.
 * remove dependency on GLib

--- a/src/output/OutputThread.cxx
+++ b/src/output/OutputThread.cxx
@@ -493,10 +493,21 @@ AudioOutput::Play()
 		in_playback_loop = false;
 	};

+	unsigned n = 0;
+
 	do {
 		if (command != Command::NONE)
 			return true;

+		if (++n >= 64) {
+			/* wake up the player every now and then to
+			   give it a chance to refill the pipe before
+			   it runs empty */
+			const ScopeUnlock unlock(mutex);
+			player_control->LockSignal();
+			n = 0;
+		}
+
 		if (!PlayChunk(chunk))
 			break;