This fixes 5 potential bugs where the conditional would always be true.

src/charConv.c

@@ -122,7 +122,7 @@ char *convStrDup(char *string)
 			    iconv(char_conv_iconv, &string, &inleft, &bufferPtr,
 				  &outleft);
 			if (outleft == BUFFER_SIZE
-			    || (err < 0 && errno != E2BIG)) {
+			    || (err == -1L && errno != E2BIG)) {
 				free(ret);
 				return NULL;
 			}

src/inputPlugins/_ogg_common.c

@@ -40,7 +40,7 @@ ogg_stream_type ogg_stream_type_detect(InputStream * inStream)
 
 	while (to_read) {
 		r = readFromInputStream(inStream, buf, 1, to_read);
-		if (r < 0)
+		if (r < inStream->error)
 			break;
 		to_read -= r;
 		if (!r && !inputStreamAtEOF(inStream))

src/inputPlugins/aac_plugin.c

@@ -239,7 +239,7 @@ static float getAacFloatTotalTime(char *file)
 	unsigned int sampleRate;
 	unsigned char channels;
 	InputStream inStream;
-	size_t bread;
+	long bread;
 
 	if (openInputStream(&inStream, file) < 0)
 		return -1;
@@ -291,7 +291,7 @@ static int aac_decode(OutputBuffer * cb, DecoderControl * dc, char *path)
 	faacDecHandle decoder;
 	faacDecFrameInfo frameInfo;
 	faacDecConfigurationPtr config;
-	size_t bread;
+	long bread;
 	unsigned int sampleRate;
 	unsigned char channels;
 	int eof = 0;

src/myfprintf.c

@@ -36,7 +36,7 @@
 static void blockingWrite(const int fd, const char *string, size_t len)
 {
 	while (len) {
-		size_t ret = xwrite(fd, string, len);
+		ssize_t ret = xwrite(fd, string, len);
 		if (ret == len)
 			return;
 		if (ret >= 0) {