player_thread: don't leak empty music_chunks

When a music_chunk only contains a tag but no PCM data, play_chunk() returns true without freeing the chunk. The caller now assumes that the chunk is moved into some music_pipe and does not bother to free it either.

player_thread: don't leak empty music_chunks
aa7f5dec · Max Kellermann · 1800bde3 · aa7f5dec
Commit aa7f5dec authored Jun 02, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

player_thread.c src/player_thread.c +3 -1

No files found.
--- a/src/player_thread.c
+++ b/src/player_thread.c
@@ -447,8 +447,10 @@ play_chunk(struct song *song, struct music_chunk *chunk,
 		}
 	}

-	if (chunk->length == 0)
+	if (chunk->length == 0) {
+		music_buffer_return(player_buffer, chunk);
 		return true;
+	}

 	pc.elapsed_time = chunk->times;
 	pc.bit_rate = chunk->bit_rate;