decoder/sidplay: free songlength data blob in error handler

When parsing the songlength database fails, the code forgot to free the memory allocated by the raw file data.

decoder/sidplay: free songlength data blob in error handler
aec18c74 · Max Kellermann · 4729d10b · aec18c74
Commit aec18c74 authored Sep 24, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

sidplay_plugin.cxx src/decoder/sidplay_plugin.cxx +4 -3

No files found.
--- a/src/decoder/sidplay_plugin.cxx
+++ b/src/decoder/sidplay_plugin.cxx
@@ -61,8 +61,10 @@ sidplay_load_songlength_db(const char *path)
 			data[i] = '#';

 	GKeyFile *db = g_key_file_new();
-	if (!g_key_file_load_from_data(db, data, size,
-				       G_KEY_FILE_NONE, &error)) {
+	bool success = g_key_file_load_from_data(db, data, size,
+						 G_KEY_FILE_NONE, &error);
+	g_free(data);
+	if (!success) {
 		g_warning("unable to parse songlengths file %s: %s",
 			  path, error->message);
 		g_error_free(error);
@@ -71,7 +73,6 @@ sidplay_load_songlength_db(const char *path)
 	}

 	g_key_file_set_list_separator(db, ' ');
-	g_free(data);
 	return db;
 }