configure.ac, unix/Daemon: check for initgroups() at configure time

The initgroups() manpage says we need to check for _BSD_SOURCE. The thing is that glibc deprecated this macro, and doesn't define it anymore, effectively breaking all MPD supplementary groups. The real fix is to check for initgroups() availability at configure time, instead of relying on the deprecated _BSD_SOURCE macro.

configure.ac, unix/Daemon: check for initgroups() at configure time
b3460f3f · Max Kellermann · 1e0ad1f6 · b3460f3f · b3460f3f · b3460f3f
Commit b3460f3f authored Feb 23, 2016 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

NEWS NEWS +1 -0

configure.ac configure.ac +1 -0

Daemon.cxx src/unix/Daemon.cxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,7 @@ ver 0.19.13 (not yet released)
  - aiff, riff: fix ID3 chunk padding
 * decoder
  - ffmpeg: support the TAK codec
+* initialize supplementary groups with glibc 2.19+

 ver 0.19.12 (2015/12/15)
 * fix assertion failure on malformed UTF-8 tag

--- a/configure.ac
+++ b/configure.ac
@@ -206,6 +206,7 @@ if test x$host_is_linux = xyes; then
 fi

 AC_CHECK_FUNCS(getpwnam_r getpwuid_r)
+AC_CHECK_FUNCS(initgroups)
 AC_CHECK_FUNCS(strndup)

 if test x$host_is_linux = xyes; then

--- a/src/unix/Daemon.cxx
+++ b/src/unix/Daemon.cxx
@@ -110,7 +110,7 @@ daemonize_set_user(void)
 				       (int)user_gid);
 	}

-#ifdef _BSD_SOURCE
+#ifdef HAVE_INITGROUPS
 	/* init supplementary groups
 	 * (must be done before we change our uid)
 	 */