ls: reimplement getSuffix() with strrchr()

The old getSuffix() code was quite wasteful, and can be replaced completely with strrchr().

ls: reimplement getSuffix() with strrchr()
b765c62f · Max Kellermann · d0024c07 · b765c62f
Commit b765c62f authored Dec 16, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 8 deletions

ls.c src/ls.c +2 -8

No files found.
--- a/src/ls.c
+++ b/src/ls.c
@@ -59,15 +59,9 @@ bool isRemoteUrl(const char *url)
 /* suffixes should be ascii only characters */
 const char *getSuffix(const char *utf8file)
 {
-	const char *ret = NULL;
+	const char *dot = strrchr(utf8file, '.');

-	while (*utf8file) {
-		if (*utf8file == '.')
-			ret = utf8file + 1;
-		utf8file++;
-	}
-
-	return ret;
+	return dot != NULL ? dot + 1 : NULL;
 }

 const struct decoder_plugin *