input/thread: set InputStream::ready after Open() failure

Without setting the "ready" flag, the caller will wait in WaitReady() forever, locking up MPD. Closes #252

input/thread: set InputStream::ready after Open() failure
c2c2c296 · Max Kellermann · c745e14f · c2c2c296 · c2c2c296
Commit c2c2c296 authored Mar 14, 2018 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

NEWS NEWS +2 -0

ThreadInputStream.cxx src/input/ThreadInputStream.cxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.20.19 (not yet released)
 * protocol
  - validate absolute seek time, reject negative values
+* input
+  - mms: fix lockup bug
 * macOS: fix crash bug

 ver 0.20.18 (2018/02/24)

--- a/src/input/ThreadInputStream.cxx
+++ b/src/input/ThreadInputStream.cxx
@@ -68,7 +68,7 @@ ThreadInputStream::ThreadFunc()
 		Open();
 	} catch (...) {
 		postponed_exception = std::current_exception();
-		cond.broadcast();
+		SetReady();
 		return;
 	}