Skip to content

M
mpd
Commit c7748fed authored by Max Kellermann's avatar Max Kellermann
Browse files
Options

output/shout: fix memory leak in error handler

parent c392efb4
Hide whitespace changes
Inline Side-by-side
Showing with 9 additions and 3 deletions
NEWS
View file @ c7748fed
ver 0.17.3 (2012/??/??) ver 0.17.3 (2012/??/??)
* output:
- shout: fix memory leak in error handler
ver 0.17.2 (2012/09/30) ver 0.17.2 (2012/09/30)
* protocol: * protocol:
......
src/output/shout_output_plugin.c
View file @ c7748fed
...@@ -439,8 +439,13 @@ my_shout_open_device(struct audio_output *ao, struct audio_format *audio_format, ...@@ -439,8 +439,13 @@ my_shout_open_device(struct audio_output *ao, struct audio_format *audio_format,
sd->buf.len = 0; sd->buf.len = 0;
if (!encoder_open(sd->encoder, audio_format, error) || if (!encoder_open(sd->encoder, audio_format, error)) {
!write_page(sd, error)) { shout_close(sd->shout_conn);
return false;
}
if (!write_page(sd, error)) {
encoder_close(sd->encoder);
shout_close(sd->shout_conn); shout_close(sd->shout_conn);
return false; return false;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment