outputs/pipewire: fix ParamChanged incorrectly setting volume

Previous versions of MPD would, on parameter change, set the PipeWire volume before clearing the restore_volume flag, causing the call to short circuit and do nothing. Instead, clear the flag before the call.

outputs/pipewire: fix ParamChanged incorrectly setting volume
c7a43551 · Arsen Arsenović · Max Kellermann · 33a84a8c · c7a43551 · c7a43551
Commit c7a43551 authored Mar 09, 2022 by Arsen Arsenović Committed by Max Kellermann Apr 26, 2022
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

NEWS NEWS +1 -0

PipeWireOutputPlugin.cxx src/output/plugins/PipeWireOutputPlugin.cxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -4,6 +4,7 @@ ver 0.23.7 (not yet released)
 * output
  - shout: require at least libshout 2.4.0
 * mixer
+  - pipewire: fix volume restore
  - software: update volume of disabled outputs
 * support libiconv


--- a/src/output/plugins/PipeWireOutputPlugin.cxx
+++ b/src/output/plugins/PipeWireOutputPlugin.cxx
@@ -638,8 +638,8 @@ PipeWireOutput::ParamChanged([[maybe_unused]] uint32_t id,
 			     [[maybe_unused]] const struct spa_pod *param) noexcept
 {
 	if (restore_volume) {
-		SetVolume(volume);
 		restore_volume = false;
+		SetVolume(volume);
 	}

 #if defined(ENABLE_DSD) && defined(SPA_AUDIO_DSD_FLAG_NONE)