Client: assume uid==0 is local socket

A negative uid value means it's not a "local socket" (PF_LOCAL). uid==0 means user "root" connected.

Client: assume uid==0 is local socket
c8b93d65 · Max Kellermann · 3f5f96ac · c8b93d65 · c8b93d65 · c8b93d65
Commit c8b93d65 authored Nov 18, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

NEWS NEWS +1 -0

Client.hxx src/Client.hxx +1 -1

ClientFile.cxx src/ClientFile.cxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,7 @@ ver 0.18.18 (not yet released)
 * decoder
  - ffmpeg: support opus
 * fix crash on failed filename charset conversion
+* fix local socket detection from uid=0 (root)

 ver 0.18.17 (2014/11/02)
 * playlist

--- a/src/Client.hxx
+++ b/src/Client.hxx
@@ -109,7 +109,7 @@ public:
 	 * a local (UNIX domain) socket?
 	 */
 	bool IsLocal() const {
-		return uid > 0;
+		return uid >= 0;
 	}

 	unsigned GetPermission() const {

--- a/src/ClientFile.cxx
+++ b/src/ClientFile.cxx
@@ -47,7 +47,7 @@ client_allow_file(const Client &client, Path path_fs, Error &error)
 		   instance */
 		return true;

-	if (uid <= 0) {
+	if (uid < 0) {
 		/* unauthenticated client */
 		error.Set(ack_domain, ACK_ERROR_PERMISSION, "Access denied");
 		return false;