storage/plugins/CurlStorage: don't use glibc extension in

ParseTimePoint. %Z is a glibc extension to strptime, and is a no-op there, due to the mapping between timezone names and their definition (especially when the name comes from a different machine) being ambiguous / impossible. Time in HTTP headers is guaranteed to be UTC. Passing an unknown format to strptime() implementations that don't support it will generally cause them to return NULL, which will lead to ParseTimePoint throwing an exception and ParseTimeStamp using an unnecessary fallback. Since the timezone name goes at the end of the string, we don't need to use %Z to skip it (could be an issue in a different time stamp format), so simply removing %Z works best.

storage/plugins/CurlStorage: don't use glibc extension in
c95e3dc0 · Érico Rolim · Max Kellermann · 00a520a4 · c95e3dc0 · c95e3dc0
Commit c95e3dc0 authored Feb 25, 2021 by Érico Rolim Committed by Max Kellermann Mar 04, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

NEWS NEWS +2 -0

CurlStorage.cxx src/storage/plugins/CurlStorage.cxx +1 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.22.7 (not yet released)
 * decoder
  - ffmpeg: fix build problem with FFmpeg 3.4
+* storage
+  - curl: don't use glibc extension

 ver 0.22.6 (2021/02/16)
 * fix missing tags on songs in queue

--- a/src/storage/plugins/CurlStorage.cxx
+++ b/src/storage/plugins/CurlStorage.cxx
@@ -193,7 +193,7 @@ ParseTimeStamp(const char *s)
 {
 	try {
 		// TODO: make this more robust
-		return ParseTimePoint(s, "%a, %d %b %Y %T %Z");
+		return ParseTimePoint(s, "%a, %d %b %Y %T");
 	} catch (...) {
 		return std::chrono::system_clock::time_point::min();
 	}