This fixes a bug where a client sending just the right data could cause mpd

to segfault. This could be exploited by malicious users to crash other users' mpd. But more importantly, I believe clients are doing this unintentionally, and that this is what is causing mpd to segfault for many people after running for long periods of time. git-svn-id: https://svn.musicpd.org/mpd/trunk@5649 09075e82-0dd4-0310-85a5-a0d7c8717e4f

This fixes a bug where a client sending just the right data could cause mpd
ce2efb48 · J. Alexander Treuman · b1d50567 · ce2efb48
Commit ce2efb48 authored Mar 18, 2007 by J. Alexander Treuman
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 0 deletions

interface.c src/interface.c +1 -0

No files found.
--- a/src/interface.c
+++ b/src/interface.c
@@ -398,6 +398,7 @@ static int processBytesRead(Interface * interface, int bytesRead)
 				return 1;
 			}
 			if (interface->cmd_list_OK >= 0 &&
+			    interface->cmd_list &&
 			    !interface->cmd_list_dup)
 				cmd_list_clone(interface);
 			interface->bufferLength -= interface->bufferPos;