update: song_file_new() cannot fail

Removed the NULL check. If that NULL check was correct, that would have been a memory leak (vtrack).

update: song_file_new() cannot fail
d1ba27d8 · Max Kellermann · 2c908fde · d1ba27d8
Commit d1ba27d8 authored Oct 16, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 0 additions and 3 deletions

update.c src/update.c +0 -3

No files found.
--- a/src/update.c
+++ b/src/update.c
@@ -459,8 +459,6 @@ update_container_file(	struct directory* directory,
 	while ((vtrack = plugin->container_scan(pathname, ++tnum)) != NULL)
 	{
 		struct song* song = song_file_new(vtrack, contdir);
-		if (song == NULL)
-			return true;

 		// shouldn't be necessary but it's there..
 		song->mtime = st->st_mtime;
@@ -468,7 +466,6 @@ update_container_file(	struct directory* directory,
 		song->tag = plugin->tag_dup(map_directory_child_fs(contdir, vtrack));

 		songvec_add(&contdir->songs, song);
-		song = NULL;

 		modified = true;