main: handle negative strtol return value

size_t is unsigned most of the time, so we can't really use it to check for negative values. Also handle strtol overflow.

main: handle negative strtol return value
d22df291 · Jonathan Neuschäfer · e77d96cf · d22df291
Commit d22df291 authored Feb 15, 2012 by Jonathan Neuschäfer
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

main.c src/main.c +3 -2

No files found.
--- a/src/main.c
+++ b/src/main.c
@@ -258,10 +258,11 @@ initialize_decoder_and_player(void)

 	param = config_get_param(CONF_AUDIO_BUFFER_SIZE);
 	if (param != NULL) {
-		buffer_size = strtol(param->value, &test, 10);
-		if (*test != '\0' || buffer_size <= 0)
+		long tmp = strtol(param->value, &test, 10);
+		if (*test != '\0' || tmp <= 0 || tmp == LONG_MAX)
 			MPD_ERROR("buffer size \"%s\" is not a positive integer, "
 				  "line %i\n", param->value, param->line);
+		buffer_size = tmp;
 	} else
 		buffer_size = DEFAULT_BUFFER_SIZE;