output/recorder: fix write() error check

We can only check for negative values if the variable is signed.

output/recorder: fix write() error check
d34e55c3 · Max Kellermann · fbcbcdc0 · d34e55c3 · d34e55c3
Commit d34e55c3 authored Oct 02, 2012 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

NEWS NEWS +1 -0

recorder_output_plugin.c src/output/recorder_output_plugin.c +3 -3

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.17.3 (2012/??/??)
 * output:
+  - recorder: fix I/O error check
  - shout: fix memory leak in error handler

 ver 0.17.2 (2012/09/30)

--- a/src/output/recorder_output_plugin.c
+++ b/src/output/recorder_output_plugin.c
@@ -140,9 +140,9 @@ recorder_output_encoder_to_file(struct recorder_output *recorder,

 	size_t position = 0;
 	while (true) {
-		size_t nbytes = write(recorder->fd,
-				      recorder->buffer + position,
-				      size - position);
+		ssize_t nbytes = write(recorder->fd,
+				       recorder->buffer + position,
+				       size - position);
 		if (nbytes > 0) {
 			position += (size_t)nbytes;
 			if (position >= size)