command: converted COMMAND_RETURN_* macros to enum

Also add names for "error" and "ok". I don't like passing anonymous integer codes around. This is not yet complete: lots of functions (e.g. in playlist.c) follow the same convention of -1/0, and these have to be adapted, too.

command: converted COMMAND_RETURN_* macros to enum
d4f3c090 · Max Kellermann · d11ee658 · d4f3c090 · d4f3c090
Commit d4f3c090 authored Oct 22, 2008 by Max Kellermann
Expand all Hide whitespace changes
Inline Side-by-side

Showing with 8 additions and 5 deletions

command.c src/command.c +0 -0

command.h src/command.h +8 -5

No files found.
--- a/src/command.c
+++ b/src/command.c
--- a/src/command.h
+++ b/src/command.h
@@ -23,9 +23,12 @@
 #include "sllist.h"
 #include "ack.h"

-#define COMMAND_RETURN_KILL	10
-#define COMMAND_RETURN_CLOSE	20
-#define COMMAND_MASTER_READY	30
+enum command_return {
+	COMMAND_RETURN_ERROR = -1,
+	COMMAND_RETURN_OK = 0,
+	COMMAND_RETURN_KILL = 10,
+	COMMAND_RETURN_CLOSE = 20,
+};

 struct client;

@@ -33,11 +36,11 @@ void command_init(void);

 void command_finish(void);

-int
+enum command_return
 command_process_list(struct client *client,
 		     int list_ok, struct strnode *list);

-int
+enum command_return
 command_process(struct client *client, char *commandString);

 void command_success(struct client *client);