db/DatabasePlaylist: increment only one variable

Fixes "searchaddpl" bug emitting bogus error "Bad position". Closes https://github.com/MusicPlayerDaemon/MPD/issues/1338

db/DatabasePlaylist: increment only one variable
dcb5ca20 · Max Kellermann · 77df5a8f · dcb5ca20 · dcb5ca20
Commit dcb5ca20 authored Nov 22, 2021 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

NEWS NEWS +2 -0

DatabasePlaylist.cxx src/db/DatabasePlaylist.cxx +1 -2

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.23.5 (not yet released)
+* protocol
+  - fix "searchaddpl" bug (bogus error "Bad position")
 * migrate to PCRE2
 * GCC 12 build fixes


--- a/src/db/DatabasePlaylist.cxx
+++ b/src/db/DatabasePlaylist.cxx
@@ -53,10 +53,9 @@ SearchInsertIntoPlaylist(const Database &db, const Storage *storage,

 	unsigned n = 0;

-	db.Visit(selection, [&playlist, &position, &n, storage](const auto &song){
+	db.Visit(selection, [&playlist, position, &n, storage](const auto &song){
 		playlist.Insert(position + n,
 				DatabaseDetachSong(storage, song));
-		++position;
 		++n;
 	});