decoder/mikmod: fix memory leak

The return value of Player_LoadTitle() is allocated with malloc(), and must be freed by the caller.

decoder/mikmod: fix memory leak
de8f2739 · Max Kellermann · 2c1c5888 · de8f2739 · de8f2739
Commit de8f2739 authored May 31, 2010 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

NEWS NEWS +1 -0

mikmod_decoder_plugin.c src/decoder/mikmod_decoder_plugin.c +4 -2

No files found.
--- a/NEWS
+++ b/NEWS
@@ -39,6 +39,7 @@ ver 0.16 (20??/??/??)
  - wavpack: allow more than 2 channels
  - mp4ff: rename plugin "mp4" to "mp4ff"
  - mp4ff: support tags "albumartist", "band"
+  - mikmod: fix memory leak
 * encoders:
  - twolame: new encoder plugin based on libtwolame
  - flac: new encoder plugin based on libFLAC

--- a/src/decoder/mikmod_decoder_plugin.c
+++ b/src/decoder/mikmod_decoder_plugin.c
@@ -195,11 +195,13 @@ mikmod_decoder_tag_dup(const char *path_fs)

 	tag->time = 0;

-	char *title = g_strdup(Player_LoadTitle(path2));
+	char *title = Player_LoadTitle(path2);
 	g_free(path2);

-	if (title)
+	if (title != NULL) {
 		tag_add_item(tag, TAG_TITLE, title);
+		free(title);
+	}

 	return tag;
 }