update: free deleted subdirectories

Use delete_directory() for removing sub directories instead of dirvec_clear(). This ensures that all memory occupied by subdirectories of deleted directories is freed.

update: free deleted subdirectories
df9245c2 · Max Kellermann · 16bab601 · df9245c2 · df9245c2
Commit df9245c2 authored Feb 12, 2009 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 2 deletions

NEWS NEWS +1 -0

update.c src/update.c +6 -2

No files found.
--- a/NEWS
+++ b/NEWS
@@ -61,6 +61,7 @@ ver 0.14.2 (2009/??/??)
 * mapper: remove trailing slashes from music_directory
 * player: set player error when output device fails
 * update: recursively purge deleted directories
+* update: free deleted subdirectories


 ver 0.14.1 (2009/01/17)

--- a/src/update.c
+++ b/src/update.c
@@ -132,6 +132,9 @@ delete_each_song(struct song *song, G_GNUC_UNUSED void *data)
 	return 0;
 }

+static void
+delete_directory(struct directory *directory);
+
 /**
 * Recursively remove all sub directories and songs from a directory,
 * leaving an empty directory.
@@ -142,8 +145,9 @@ clear_directory(struct directory *directory)
 	int i;

 	for (i = directory->children.nr; --i >= 0;)
-		clear_directory(directory->children.base[i]);
-	dirvec_clear(&directory->children);
+		delete_directory(directory->children.base[i]);
+
+	assert(directory->children.nr == 0);

 	songvec_for_each(&directory->songs, delete_each_song, directory);
 }