player/Thread: remove redundant outputs.Cancel() call

The STOP, EXIT and CLOSE_AUDIO commands are not finished here; they are propagated to PlayerControl::RunThread() where the outputs.Cancel() call will be done again.

player/Thread: remove redundant outputs.Cancel() call
e31abe6d · Max Kellermann · e1349cca · e31abe6d
Commit e31abe6d authored Dec 28, 2017 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 1 addition and 4 deletions

Thread.cxx src/player/Thread.cxx +1 -4

No files found.
--- a/src/player/Thread.cxx
+++ b/src/player/Thread.cxx
@@ -989,11 +989,8 @@ Player::Run() noexcept
 	pc.CommandFinished();

 	while (true) {
-		if (!ProcessCommand()) {
-			const ScopeUnlock unlock(pc.mutex);
-			pc.outputs.Cancel();
+		if (!ProcessCommand())
 			break;
-		}

 		if (buffering) {
 			/* buffering at the start of the song - wait