GME Plugin: fix track numbering

GME starts all track indexes at zero, but subtune prefixes start at one. This fixes an off-by-one error during track enumeration.

GME Plugin: fix track numbering
ea80587d · John Regan · Max Kellermann · 828f5f83 · ea80587d · ea80587d
Commit ea80587d authored Sep 26, 2017 by John Regan Committed by Max Kellermann Sep 27, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

NEWS NEWS +1 -0

GmeDecoderPlugin.cxx src/decoder/plugins/GmeDecoderPlugin.cxx +2 -2

No files found.
--- a/NEWS
+++ b/NEWS
@@ -3,6 +3,7 @@ ver 0.20.11 (not yet released)
  - curl: support Content-Type application/xml
 * decoder
  - ffmpeg: more reliable song duration
+  - gme: fix track numbering
 * fix case insensitive search without libicu

 ver 0.20.10 (2017/08/24)

--- a/src/decoder/plugins/GmeDecoderPlugin.cxx
+++ b/src/decoder/plugins/GmeDecoderPlugin.cxx
@@ -293,13 +293,13 @@ gme_container_scan(Path path_fs)
 	TagBuilder tag_builder;

 	auto tail = list.before_begin();
-	for (unsigned i = 1; i <= num_songs; ++i) {
+	for (unsigned i = 0; i < num_songs; ++i) {
 		ScanMusicEmu(emu, i,
 			     add_tag_handler, &tag_builder);

 		char track_name[64];
 		snprintf(track_name, sizeof(track_name),
-			 SUBTUNE_PREFIX "%03u.%s", i, subtune_suffix);
+			 SUBTUNE_PREFIX "%03u.%s", i+1, subtune_suffix);
 		tail = list.emplace_after(tail, track_name,
 					  tag_builder.Commit());
 	}