change errno.h to cerrno

The former is deprecated by C++14. It's also functionally the same. From the standard: 19.4 The header<cerrno>is described in Table 43. Its contents are the same as the POSIX header<errno.h>,except that errno shall be defined as a macro. [Note: The intent is to remain in close alignment with the POSIX standard.] A separate errno value shall be provided for each thread. Signed-off-by: Rosen Penev <rosenp@gmail.com>

change errno.h to cerrno
edc4989d · Rosen Penev · 2b3d6461 · edc4989d · edc4989d · edc4989d
Unverified Commit edc4989d authored Mar 12, 2020 by Rosen Penev
18 changed files
--- a/src/Log.cxx
+++ b/src/Log.cxx
@@ -21,9 +21,10 @@
 #include "util/Domain.hxx"
 #include "util/Exception.hxx"

+#include <cerrno>
+
 #include <stdio.h>
 #include <string.h>
-#include <errno.h>

 static constexpr Domain exception_domain("exception");


--- a/src/db/plugins/simple/SimpleDatabasePlugin.cxx
+++ b/src/db/plugins/simple/SimpleDatabasePlugin.cxx
@@ -49,10 +49,9 @@
 #include "fs/io/GzipOutputStream.hxx"
 #endif

+#include <cerrno>
 #include <memory>

-#include <errno.h>
-
 static constexpr Domain simple_db_domain("simple_db");

 inline SimpleDatabase::SimpleDatabase(const ConfigBlock &block)

--- a/src/db/update/InotifySource.cxx
+++ b/src/db/update/InotifySource.cxx
@@ -24,8 +24,9 @@
 #include "system/Error.hxx"
 #include "Log.hxx"

+#include <cerrno>
+
 #include <sys/inotify.h>
-#include <errno.h>
 #include <stdint.h>
 #include <limits.h>


--- a/src/db/update/UpdateIO.cxx
+++ b/src/db/update/UpdateIO.cxx
@@ -26,7 +26,7 @@
 #include "fs/AllocatedPath.hxx"
 #include "Log.hxx"

-#include <errno.h>
+#include <cerrno>

 bool
 GetInfo(Storage &storage, const char *uri_utf8, StorageFileInfo &info) noexcept

--- a/src/db/update/Walk.cxx
+++ b/src/db/update/Walk.cxx
@@ -39,12 +39,12 @@
 #include "Log.hxx"

 #include <cassert>
+#include <cerrno>
 #include <exception>
 #include <memory>

 #include <string.h>
 #include <stdlib.h>
-#include <errno.h>

 UpdateWalk::UpdateWalk(const UpdateConfig &_config,
 		       EventLoop &_loop, DatabaseListener &_listener,

--- a/src/event/MultiSocketMonitor.cxx
+++ b/src/event/MultiSocketMonitor.cxx
@@ -23,7 +23,7 @@
 #include <algorithm>

 #ifdef USE_EPOLL
-#include <errno.h>
+#include <cerrno>
 #endif

 #ifndef _WIN32

--- a/src/fs/FileSystem.cxx
+++ b/src/fs/FileSystem.cxx
@@ -22,7 +22,8 @@
 #include "Limits.hxx"
 #include "system/Error.hxx"

-#include <errno.h>
+#include <cerrno>
+
 #include <fcntl.h>

 void

--- a/src/fs/io/FileOutputStream.cxx
+++ b/src/fs/io/FileOutputStream.cxx
@@ -158,9 +158,10 @@ FileOutputStream::Cancel() noexcept

 #else

+#include <cerrno>
+
 #include <fcntl.h>
 #include <unistd.h>
-#include <errno.h>

 #ifdef HAVE_O_TMPFILE
 #ifndef O_TMPFILE

--- a/src/lib/xiph/FlacIOHandle.cxx
+++ b/src/lib/xiph/FlacIOHandle.cxx
@@ -22,7 +22,8 @@
 #include "util/Compiler.h"
 #include "system/Error.hxx"

-#include <errno.h>
+#include <cerrno>
+
 #include <stdio.h>

 static size_t

--- a/src/net/Resolver.cxx
+++ b/src/net/Resolver.cxx
@@ -44,9 +44,10 @@
 #include <net/if.h>
 #endif

+#include <cerrno>
+
 #include <string.h>
 #include <stdio.h>
-#include <errno.h>

 static inline bool
 ai_is_passive(const struct addrinfo *ai)

--- a/src/net/SocketDescriptor.cxx
+++ b/src/net/SocketDescriptor.cxx
@@ -42,7 +42,8 @@
 #include <netinet/tcp.h>
 #endif

-#include <errno.h>
+#include <cerrno>
+
 #include <string.h>

 int

--- a/src/net/SocketError.hxx
+++ b/src/net/SocketError.hxx
@@ -27,7 +27,7 @@
 #include <winsock2.h>
 typedef DWORD socket_error_t;
 #else
-#include <errno.h>
+#include <cerrno>
 typedef int socket_error_t;
 #endif


--- a/src/output/plugins/FifoOutputPlugin.cxx
+++ b/src/output/plugins/FifoOutputPlugin.cxx
@@ -28,8 +28,9 @@
 #include "Log.hxx"
 #include "open.h"

+#include <cerrno>
+
 #include <sys/stat.h>
-#include <errno.h>
 #include <unistd.h>

 class FifoOutput final : AudioOutput {

--- a/src/output/plugins/OssOutputPlugin.cxx
+++ b/src/output/plugins/OssOutputPlugin.cxx
@@ -28,13 +28,13 @@
 #include "Log.hxx"

 #include <cassert>
+#include <cerrno>
 #include <iterator>
 #include <stdexcept>

 #include <sys/stat.h>
 #include <sys/ioctl.h>
 #include <fcntl.h>
-#include <errno.h>
 #include <stdlib.h>
 #include <unistd.h>


--- a/src/output/plugins/SolarisOutputPlugin.cxx
+++ b/src/output/plugins/SolarisOutputPlugin.cxx
@@ -22,12 +22,13 @@
 #include "system/FileDescriptor.hxx"
 #include "system/Error.hxx"

+#include <cerrno>
+
 #include <sys/ioctl.h>
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <unistd.h>
 #include <fcntl.h>
-#include <errno.h>

 #if defined(__sun)
 #include <sys/audio.h>

--- a/src/system/Error.hxx
+++ b/src/system/Error.hxx
@@ -92,7 +92,8 @@ FormatLastError(const char *fmt, Args&&... args) noexcept

 #endif /* _WIN32 */

-#include <errno.h>
+#include <cerrno>
+
 #include <string.h>

 /**

--- a/src/system/FatalError.cxx
+++ b/src/system/FatalError.cxx
@@ -30,7 +30,7 @@
 #ifdef _WIN32
 #include <windows.h>
 #else
-#include <errno.h>
+#include <cerrno>
 #endif

 static constexpr Domain fatal_error_domain("fatal_error");

--- a/test/WriteFile.cxx
+++ b/test/WriteFile.cxx
@@ -20,8 +20,9 @@
 #include "fs/io/FileOutputStream.hxx"
 #include "util/PrintException.hxx"

+#include <cerrno>
+
 #include <unistd.h>
-#include <errno.h>

 #include <string.h>
 #include <stdlib.h>