client: check expired after client_process_line()

The assertion on "!client_is_expired(client)" was wrong, because writing the command response may cause the client to become expired. Replace that assertion with a check.

client: check expired after client_process_line()
ef0e2fdc · Max Kellermann · 79a14c9a · ef0e2fdc
Commit ef0e2fdc authored Sep 17, 2008 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

client.c src/client.c +3 -1

No files found.
--- a/src/client.c
+++ b/src/client.c
@@ -417,7 +417,9 @@ static int client_input_received(struct client *client, int bytesRead)
 			if (ret == COMMAND_RETURN_KILL ||
 			    ret == COMMAND_RETURN_CLOSE)
 				return ret;
-			assert(!client_is_expired(client));
+			if (client_is_expired(client))
+				return COMMAND_RETURN_CLOSE;
+
 			client->bufferPos = client->bufferLength;
 		}
 		if (client->bufferLength == CLIENT_MAX_BUFFER_LENGTH) {