include cleanups (powered by iwyu)

src/fs/Charset.cxx

@@ -33,7 +33,6 @@
 #include <algorithm>
 
 #include <assert.h>
-#include <string.h>
 
 #ifdef HAVE_FS_CHARSET
 

src/input/plugins/TidalErrorParser.cxx

@@ -20,7 +20,6 @@
 #include "TidalErrorParser.hxx"
 #include "TidalError.hxx"
 #include "lib/yajl/Callbacks.hxx"
-#include "util/ConstBuffer.hxx"
 #include "util/RuntimeError.hxx"
 
 using Wrapper = Yajl::CallbacksWrapper<TidalErrorParser>;

src/lib/curl/Delegate.cxx

@@ -30,6 +30,8 @@
 #include "Delegate.hxx"
 #include "Parser.hxx"
 
+#include <utility>
+
 #include <assert.h>
 
 void

src/lib/dbus/Message.cxx

 /*
- * Copyright 2007-2017 Content Management AG
+ * Copyright 2007-2019 Content Management AG
  * All rights reserved.
  *
  * author: Max Kellermann <mk@cm4all.com>
@@ -33,6 +33,8 @@
 #include "Message.hxx"
 #include "ReadIter.hxx"
 
+#include <stdexcept>
+
 ODBus::Message
 ODBus::Message::NewMethodCall(const char *destination,
 			      const char *path,

src/lib/dbus/Message.hxx

 /*
- * Copyright 2007-2017 Content Management AG
+ * Copyright 2007-2019 Content Management AG
  * All rights reserved.
  *
  * author: Max Kellermann <mk@cm4all.com>
@@ -35,7 +35,6 @@
 
 #include <dbus/dbus.h>
 
-#include <stdexcept>
 #include <utility>
 
 namespace ODBus {

src/lib/ffmpeg/LogError.cxx

@@ -21,8 +21,6 @@
 #include "Domain.hxx"
 #include "Log.hxx"
 
-#include <cstdint> /* needed due to libavutil bug */
-
 extern "C" {
 #include <libavutil/error.h>
 }

src/lib/icu/CaseFold.cxx

@@ -27,7 +27,6 @@
 #ifdef HAVE_ICU
 #include "Util.hxx"
 #include "util/AllocatedArray.hxx"
-#include "util/ConstBuffer.hxx"
 
 #include <unicode/ucol.h>
 #include <unicode/ustring.h>

src/lib/icu/Converter.cxx

@@ -20,7 +20,6 @@
 #include "Converter.hxx"
 #include "util/AllocatedString.hxx"
 #include "util/AllocatedArray.hxx"
-#include "util/ConstBuffer.hxx"
 #include "util/FormatString.hxx"
 #include "config.h"
 

src/lib/icu/Util.cxx

@@ -20,7 +20,6 @@
 #include "Util.hxx"
 #include "util/AllocatedString.hxx"
 #include "util/AllocatedArray.hxx"
-#include "util/WritableBuffer.hxx"
 #include "util/ConstBuffer.hxx"
 
 #include <unicode/ustring.h>

src/playlist/plugins/FlacPlaylistPlugin.cxx

@@ -31,7 +31,6 @@
 #include "song/DetachedSong.hxx"
 #include "input/InputStream.hxx"
 #include "util/RuntimeError.hxx"
-#include "util/ScopeExit.hxx"
 
 #include <FLAC/metadata.h>
 

src/util/HugeAllocator.hxx

@@ -31,7 +31,6 @@
 #define HUGE_ALLOCATOR_HXX
 
 #include "WritableBuffer.hxx"
-#include "Compiler.h"
 
 #include <utility>
 
@@ -85,7 +84,7 @@ WritableBuffer<void>
 HugeAllocate(size_t size);
 
 static inline void
-HugeFree(void *p, gcc_unused size_t size) noexcept
+HugeFree(void *p, size_t) noexcept
 {
 	VirtualFree(p, 0, MEM_RELEASE);
 }

src/util/WStringCompare.cxx

 /*
- * Copyright 2013-2018 Max Kellermann <max.kellermann@gmail.com>
+ * Copyright 2013-2019 Max Kellermann <max.kellermann@gmail.com>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -29,6 +29,8 @@
 
 #include "WStringCompare.hxx"
 
+#include <string.h>
+
 bool
 StringEndsWith(const wchar_t *haystack, const wchar_t *needle) noexcept
 {

test/read_mixer.cxx

@@ -21,15 +21,11 @@
 #include "mixer/MixerControl.hxx"
 #include "mixer/MixerList.hxx"
 #include "filter/FilterRegistry.hxx"
-#include "pcm/Volume.hxx"
-#include "Main.hxx"
 #include "event/Loop.hxx"
 #include "config/Block.hxx"
 #include "util/PrintException.hxx"
 
 #include <assert.h>
-#include <string.h>
-#include <unistd.h>
 #include <stdlib.h>
 
 const FilterPlugin *

test/run_encoder.cxx

@@ -27,11 +27,11 @@
 #include "fs/io/StdioOutputStream.hxx"
 #include "util/PrintException.hxx"
 
+#include <exception>
 #include <memory>
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <stddef.h>
 #include <unistd.h>
 
 int main(int argc, char **argv)

test/run_output.cxx

@@ -24,7 +24,7 @@
 #include "event/Thread.hxx"
 #include "fs/Path.hxx"
 #include "AudioParser.hxx"
-#include "pcm/Convert.hxx"
+#include "AudioFormat.hxx"
 #include "util/StringBuffer.hxx"
 #include "util/RuntimeError.hxx"
 #include "util/ScopeExit.hxx"

test/test_vorbis_encoder.cxx

@@ -30,8 +30,8 @@
 
 #include <memory>
 
+#include <assert.h>
 #include <stddef.h>
-#include <unistd.h>
 
 static uint8_t zero[256];