fs/Charset: don't allow nullptr arguments

src/fs/Charset.cxx

@@ -79,8 +79,7 @@ GetFSCharset()
 std::string
 PathToUTF8(const char *path_fs)
 {
-	if (path_fs == nullptr)
-		return std::string();
+	assert(path_fs != nullptr);
 
 	GIConv conv = g_iconv_open("utf-8", fs_charset.c_str());
 	if (conv == reinterpret_cast<GIConv>(-1))
@@ -107,6 +106,8 @@ PathToUTF8(const char *path_fs)
 char *
 PathFromUTF8(const char *path_utf8)
 {
+	assert(path_utf8 != nullptr);
+
 	return g_convert(path_utf8, -1,
 			 fs_charset.c_str(), "utf-8",
 			 nullptr, nullptr, nullptr);

src/fs/Charset.hxx

@@ -37,13 +37,13 @@ SetFSCharset(const char *charset);
 
 /**
  * Convert the path to UTF-8.
- * Returns empty string on error or if #path_fs is null pointer.
+ * Returns empty string on error.
  */
-gcc_pure
+gcc_pure gcc_nonnull_all
 std::string
 PathToUTF8(const char *path_fs);
 
-gcc_malloc
+gcc_malloc gcc_nonnull_all
 char *
 PathFromUTF8(const char *path_utf8);
 

src/fs/Path.hxx

@@ -123,10 +123,10 @@ public:
 	 * Convert a UTF-8 C string to a #Path instance.
 	 * Returns return a "nulled" instance on error.
 	 */
-	gcc_pure
+	gcc_pure gcc_nonnull_all
 	static Path FromUTF8(const char *path_utf8);
 
-	gcc_pure
+	gcc_pure gcc_nonnull_all
 	static Path FromUTF8(const char *path_utf8, Error &error);
 
 	/**