client/Response: reimplement Error() without FmtError()

With libfmt versions older than 7, this leads to an endless recursion between Error() and FmtError(), resulting in a crash due to stack overflow. D'oh! Closes https://github.com/MusicPlayerDaemon/MPD/issues/1295

client/Response: reimplement Error() without FmtError()
fd5a3b58 · Max Kellermann · 6120c136 · fd5a3b58 · fd5a3b58
Commit fd5a3b58 authored Oct 19, 2021 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

NEWS NEWS +1 -0

Response.cxx src/client/Response.cxx +5 -1

No files found.
--- a/NEWS
+++ b/NEWS
 ver 0.23.2 (not yet released)
 * neighbor
  - mention failed plugin name in error message
+* fix crash with libfmt versions older than 7

 ver 0.23.1 (2021/10/19)
 * protocol

--- a/src/client/Response.cxx
+++ b/src/client/Response.cxx
@@ -66,7 +66,11 @@ Response::WriteBinary(ConstBuffer<void> payload) noexcept
 void
 Response::Error(enum ack code, const char *msg) noexcept
 {
-	FmtError(code, FMT_STRING("{}"), msg);
+	Fmt(FMT_STRING("ACK [{}@{}] {{{}}} "),
+	    (int)code, list_index, command);
+
+	Write(msg);
+	Write("\n");
 }

 void