decoder/faad: fix memory leak

fdd76b34 · Max Kellermann · e490e5d0 · fdd76b34 · fdd76b34
Commit fdd76b34 authored Jan 08, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

NEWS NEWS +2 -0

FaadDecoderPlugin.cxx src/decoder/FaadDecoderPlugin.cxx +2 -0

No files found.
--- a/NEWS
+++ b/NEWS
@@ -2,6 +2,8 @@ ver 0.18.7 (not yet released)
 * playlist
  - pls: fix crash after parser error
  - soundcloud: fix build failure with libyajl 2.0.1
+* decoder
+  - faad: fix memory leak
 * daemon: don't initialize supplementary groups when already running
  as the configured user


--- a/src/decoder/FaadDecoderPlugin.cxx
+++ b/src/decoder/FaadDecoderPlugin.cxx
@@ -393,6 +393,7 @@ faad_stream_decode(Decoder &mpd_decoder, InputStream &is)
 	if (!ret) {
 		LogError(error);
 		NeAACDecClose(decoder);
+		decoder_buffer_free(buffer);
 		return;
 	}

@@ -461,6 +462,7 @@ faad_stream_decode(Decoder &mpd_decoder, InputStream &is)
 	/* cleanup */

 	NeAACDecClose(decoder);
+	decoder_buffer_free(buffer);
 }

 static bool