util/PeakBuffer: fix nullptr dereference when peak_size==0

fe7cda57 · Max Kellermann · a3f9abcb · fe7cda57
Commit fe7cda57 authored Jan 14, 2014 by Max Kellermann
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

PeakBuffer.cxx src/util/PeakBuffer.cxx +3 -2

No files found.
--- a/src/util/PeakBuffer.cxx
+++ b/src/util/PeakBuffer.cxx
@@ -122,8 +122,9 @@ PeakBuffer::Append(const void *data, size_t length)
 			return true;
 	}

-	if (peak_buffer == nullptr && peak_size > 0) {
-		peak_buffer = new DynamicFifoBuffer<uint8_t>(peak_size);
+	if (peak_buffer == nullptr) {
+		if (peak_size > 0)
+			peak_buffer = new DynamicFifoBuffer<uint8_t>(peak_size);
 		if (peak_buffer == nullptr)
 			return false;
 	}