- 14 Dec, 2014 11 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
When mounting had not yet finished, SocketMonitor::IsDefined() was always false, due to the workaround at the beginning of the function that calls SocketMonitor::Steal(). This commit drops the IsDefined() check because it was never necessary and breaks reconnect.
-
Max Kellermann authored
-
Max Kellermann authored
nfs_destroy_context() will invoke all pending callbacks with err==-EINTR. In CancellableCallback::Callback(), this will invoke NfsConnection::DeferClose(), which however is only designed to be called from nfs_service(). In non-debug mode, this will leak memory because nfs_close_async() is never called. Workaround: before nfs_destroy_context(), invoke nfs_close_async() on all pending file handles.
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
The method NfsConnection::CancellableCallback::Callback() will always invoke NfsConnection::Close() on the file handle, even if the void pointer is not a nfsfh. This can happen if the Open() was not successful, e.g. when the file does not exist.
-
Max Kellermann authored
-
Max Kellermann authored
-
- 12 Dec, 2014 2 commits
-
-
Max Kellermann authored
MEM_LARGE_PAGES does not appear to work. Instead, MEM_RESERVE appears to be necessary. Until I figure this out, this large pages are disabled.
-
Max Kellermann authored
-
- 09 Dec, 2014 2 commits
-
-
Max Kellermann authored
Skipping those songs silently will confuse the client, because commands specifying the song index within a playlist (e.g. playlistdelete) will be out of sync. This copies spl_print()'s behavior to playlist_file_print().
-
Max Kellermann authored
-
- 08 Dec, 2014 7 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
Version 2.5 fixed an API oddity, however it broke API compatibility, at least with C++. Disable the workaround when a libavformat version is detected that is recent enough.
-
Max Kellermann authored
The "::" to explicitly refer to the global namespace appeared like a good idea in C++, but it breaks with C libraries that implement standard functions using macros (e.g. musl).
-
Max Kellermann authored
-
- 01 Dec, 2014 1 commit
-
-
Nix authored
There are code paths (mostly error cases) in which it is possible to initialize an AudioOutput and then kill it without ever calling audio_output_new(). In such a case, its destructor will attempt to free a mixer that was never initialized, leading to an attempt to take out a lock on a mutex that was similarly never initialized, which hangs forever. Fix by always initializing the mixer appropriately.
-
- 28 Nov, 2014 4 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Due to security vulnerabilities.
-
Max Kellermann authored
-
Max Kellermann authored
-
- 26 Nov, 2014 4 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
- 25 Nov, 2014 9 commits
-
-
Max Kellermann authored
Avoids crash because Close() invokes a call on a destructed NfsConnection.
-
Max Kellermann authored
-
Max Kellermann authored
Avoid calling NfsConnection::RemoveLease(), because the lease has been removed already.
-
Max Kellermann authored
Clean up the "state" to indicate that there is no longer any asynchronous operation. Fixes another NFS-related crash due to cleanup of a non-existing asynchronous operation.
-
Max Kellermann authored
Avoids a crash that occurs when NfsConnection::OnSocketReady() dereferences itself before returning.
-
Max Kellermann authored
During the NfsLease::OnNfsConnectionFailed() call, the old (defunct) nfs_context may be used to close file handles. Such code does not yet exist, but will be added soon to fix other bugs.
-
Max Kellermann authored
Fixes potential second mount attempt after the old connection to the NFS server was shut down.
-
Max Kellermann authored
-
Max Kellermann authored
libmp4v2 is licensed under MPL 1.1, which is incompatible with GPLv2. Unfortunately, this means that we must remove the plugin. More information can be found in the Debian bug report: http://bugs.debian.org/767504
-