Skip to content

M
mpd
Switch branch/tag
  1. 03 Jan, 2009 1 commit
  3. 29 Dec, 2008 2 commits
  5. 02 Dec, 2008 1 commit
  7. 17 Oct, 2008 1 commit
  9. 15 Oct, 2008 2 commits
    • Max Kellermann's avatar
      path, tag_id3: use g_convert() instead of charConv.c · 8746a58a
      Max Kellermann authored 
      GLib provides an easier API for character set conversion than iconv().
Use g_convert() / g_convert_with_fallback() for all character
conversions.  We should optimize the path.h API later to return a
newly allocated buffer, so we can just pass GLib's return value.
      8746a58a
    • Max Kellermann's avatar
      tag_id3: fix indentation · 2a47e90c
      Max Kellermann authored 
      Indentation was broken in tag_id3.c: it used 4 spaces instead of tabs.
      2a47e90c
  11. 29 Aug, 2008 4 commits
  13. 28 Aug, 2008 2 commits
    • Max Kellermann's avatar
      const pointers · bc1c8835
      Max Kellermann authored 
      The usual bunch of pointer arguments which should be const.
      bc1c8835
    • Max Kellermann's avatar
      unsigned integers and size_t · 801c71ed
      Max Kellermann authored 
      Use "unsigned int" whenever negative values are not meaningful.  Use
size_t whenever we are going to describe buffer sizes.
      801c71ed
  15. 26 Aug, 2008 1 commit
  17. 12 Apr, 2008 3 commits
  19. 26 Mar, 2008 2 commits
    • Max Kellermann's avatar
      use size_t · 27f12c17
      Max Kellermann authored 
      When dealing with in-memory lengths, the standard type "size_t" should
be used.  Missing one can be quite dangerous, because an attacker
could provoke an integer under-/overflow, which may provide an attack
vector.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7205 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      27f12c17
    • Max Kellermann's avatar
      eliminated duplicate initialization · c5b524e3
      Max Kellermann authored 
      Local variables which are never read before the first assignment don't
need initialization.  Saves a few bytes of text.  Also don't reset
variables which are never read until function return.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7199 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      c5b524e3
  21. 05 Feb, 2008 1 commit
  23. 26 Jan, 2008 1 commit
  25. 03 Jan, 2008 1 commit
    • Eric Wong's avatar
      Cleanup #includes of standard system headers and put them in one place · cb8f1af3
      Eric Wong authored 
      This will make refactoring features easier, especially now that
pthreads support and larger refactorings are on the horizon.

Hopefully, this will make porting to other platforms (even
non-UNIX-like ones for masochists) easier, too.

os_compat.h will house all the #includes for system headers
considered to be the "core" of MPD.  Headers for optional
features will be left to individual source files.

git-svn-id: https://svn.musicpd.org/mpd/trunk@7130 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      cb8f1af3
  27. 28 Dec, 2007 1 commit
    • Eric Wong's avatar
      Merge branches/ew r7104 · b79f6b88
      Eric Wong authored 
      thread-safety work in preparation for rewrite to use pthreads

Expect no regressions against trunk (r7078), possibly minor
performance improvements in update (due to fewer heap
allocations), but increased stack usage.

Applied the following patches:

* maxpath_str for reentrancy (temporary fix, reverted)
* path: start working on thread-safe variants of these methods
* Re-entrancy work on path/character-set conversions
* directory.c: exploreDirectory() use reentrant functions here
* directory/update: more use of reentrant functions + cleanups
* string_toupper: a strdup-less version of strDupToUpper
* get_song_url: a static-variable-free version of getSongUrl()
* Use reentrant/thread-safe get_song_url everywhere
* replace rmp2amp with the reentrant version, rmp2amp_r
* Get rid of the non-reentrant/non-thread-safe rpp2app, too.
* buffer2array: assert strdup() returns a usable value in unit tests
* replace utf8ToFsCharset and fsCharsetToUtf8 with thread-safe variants
* fix storing playlists w/o absolute paths
* parent_path(), a reentrant version of parentPath()
* parentPath => parent_path for reentrancy and thread-safety
* allow "make test" to automatically run embedded unit tests
* remove convStrDup() and maxpath_str()
* use MPD_PATH_MAX everywhere instead of MAXPATHLEN
* path: get rid of appendSlash, pfx_path and just use pfx_dir
* get_song_url: fix the ability to play songs in the top-level music_directory

git-svn-id: https://svn.musicpd.org/mpd/trunk@7106 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      b79f6b88
  29. 21 Nov, 2007 1 commit
  31. 26 May, 2007 1 commit
  33. 05 Apr, 2007 1 commit
  35. 31 Mar, 2007 1 commit
  37. 20 Mar, 2007 2 commits
  39. 09 Mar, 2007 1 commit
  41. 23 Feb, 2007 1 commit
  43. 18 Feb, 2007 1 commit
  45. 26 Nov, 2006 1 commit
  47. 11 Sep, 2006 1 commit
  49. 26 Aug, 2006 1 commit
    • Eric Wong's avatar
      Replace strdup and {c,re,m}alloc with x* variants to check for OOM errors · 90847fc8
      Eric Wong authored 
      I'm checking for zero-size allocations and assert()-ing them,
so we can more easily get backtraces and debug problems, but we'll
also allow -DNDEBUG people to live on the edge if they wish.

We do not rely on errno when checking for OOM errors because
some implementations of malloc do not set it, and malloc
is commonly overridden by userspace wrappers.

I've spent some time looking through the source and didn't find any
obvious places where we would explicitly allocate 0 bytes, so we
shouldn't trip any of those assertions.

We also avoid allocating zero bytes because C libraries don't
handle this consistently (some return NULL, some not); and it's
dangerous either way.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4690 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      90847fc8
  51. 18 Aug, 2006 2 commits
  53. 15 Aug, 2006 2 commits
  55. 11 Aug, 2006 1 commit