- 05 Jan, 2009 12 commits
-
-
Max Kellermann authored
Both are unused.
-
Max Kellermann authored
Yesterday's patch set changed tagItemFoundAndMatches() and moved the strcmp() return value into a bool, but forgot to add the ==0 check.
-
Max Kellermann authored
"#ifdef G_BYTE_ORDER == G_BIG_ENDIAN" cannot work, of course.
-
Max Kellermann authored
Zeroconf, curl, libsamplerate. No libid3tag for now, because libid3tag should be automatically disabled when no decoders using it are enabled.
-
Max Kellermann authored
Don't separate basic options from their according tests. Due to lots of interdependencies, we won't do that for the plugins yet.
-
Max Kellermann authored
Print input plugins first, then archive, metadatab, decoder, converter, encoder, output plugins.
-
Max Kellermann authored
Initialize the CFLAGS (warnings, errors) after all the libraries, because some library checks may be broken with -Werror or -pedantic.
-
Max Kellermann authored
AC_CHECK_HEADERS defines HAVE_LOCALE_H, so we don't have to manually define HAVE_LOCALE.
-
Max Kellermann authored
First do the checks for mandatory stuff (libc features, glib, pkg-config), then all the options.
-
Max Kellermann authored
Don't check for inttypes.h and langinfo.h.
-
Max Kellermann authored
-
Max Kellermann authored
Fix a typo.
-
- 04 Jan, 2009 28 commits
-
-
Max Kellermann authored
Use g_strndup() instead of g_memdup().
-
Max Kellermann authored
Make db_load(), db_save() and db_check() return bool instead of int.
-
Max Kellermann authored
For updating the database, directory_update_init() should be called explicitly.
-
Max Kellermann authored
-
Max Kellermann authored
It's unused.
-
Max Kellermann authored
The notify library is easier to use, and has no disadvantages.
-
Max Kellermann authored
-
Max Kellermann authored
Start the daemon after --create-db. This makes --create-db a flag which discards the old database and starts with a fresh one.
-
Max Kellermann authored
-
Max Kellermann authored
Handle the DELETE and UPDATE events in separate callbacks: song_delete_event() safely deletes a song, and update_finished_event() is called when database update is complete.
-
Max Kellermann authored
GLib mandates that you initialize all GError objects with NULL prior to passing it.
-
Max Kellermann authored
Pass NULL instead of &error to g_convert(). We're not interested in the error object.
-
Max Kellermann authored
Use GLib's g_build_filename() instead of pfx_dir().
-
Viliam Mateicka authored
-
Max Kellermann authored
-
Max Kellermann authored
directory_is_root() is cheaper than isRootDirectory(directory_get_path()).
-
Max Kellermann authored
-
Max Kellermann authored
Don't call command_error() if loading a song from the playlist fails. This may result in assertion failures, since command_error() may be called more than once.
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
The struct delete_data has only one member left and can be eliminated.
-
Max Kellermann authored
Determine the suffix manually, and use decoder_plugin_from_suffix() and archive_plugin_from_suffix() instead. This way, song_file_update_inarchive() can be optimized: it does not have to translate its path.
-
Max Kellermann authored
-
Max Kellermann authored
Newline characters are already checked in skip_path() (update.c).
-
Max Kellermann authored
Don't include headers which are not used. Fix some includes in decoder_thread.c.
-
Max Kellermann authored
Reverse the condition: delete directories which don't exist anymore. This typo caused a slowdown during partial database update.
-
Max Kellermann authored
For internal checks (i.e. not in command.c), we need to check whether an URI is in the databse, in the local file system or a remote URI with a scheme.
-
Max Kellermann authored
Check if the URI scheme is supported by MPD, and print an error message if not. Optimize the checks in "add" and "playlistadd".
-