- 26 Aug, 2008 40 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
The flag "ready" indicates whether the input stream is ready and it has parsed all meta data. Previously, it was impossible for decodeStart() to see the content type of HTTP input streams, because at that time, the HTTP response wasn't parsed yet.
-
Max Kellermann authored
With the functions decoder_plugin_register() and decoder_plugin_unregister(), decoder plugins can register a "secondary" plugin, like the flac input plugin does this for "oggflac".
-
Max Kellermann authored
To make the code more consistent, call quitDecode() only at the end of decodeParent().
-
Max Kellermann authored
Move code which runs in the player thread to player_thread.c. Having a lot of player thread code in decode.c isn't easy to understand.
-
Max Kellermann authored
decode.c should be a lot smaller; start by moving all code which handles cross-fading to crossfade.c. Also includes camelCase conversion.
-
Max Kellermann authored
Make the code more readable by hiding big formulas in an inline function with a nice name.
-
Max Kellermann authored
Make calculateCrossFadeChunks() more generic and portable by eliminating global variable access.
-
Max Kellermann authored
Don't use CPP macros when you can use C enum... this also allows better type checking.
-
Max Kellermann authored
InputPlugin to decoder_plugin, and no camelCase.
-
Max Kellermann authored
-
Max Kellermann authored
Continuing the effort to rename InputPlugin to decoder_plugin...
-
Max Kellermann authored
Since inputPlugin.c manages the list of registered decoders, we should rename the source file.
-
Max Kellermann authored
The decoder_plugin instances are only used inputPlugin.c, so move them from the header file.
-
Max Kellermann authored
"decoder plugin" is a better name than "input plugin", since the plugin does not actually do the input - InputStream does. Also don't use typedef, so we can forward-declare it if required.
-
Max Kellermann authored
The function player_command() inherited the busy-waiting algorithm from the old code; throw in a wait_main_task() to do idle waiting.
-
Max Kellermann authored
Don't write CPP when you can express the same in C... macros vs enum is a good example for that.
-
Max Kellermann authored
PlayerControl.command replaces the old attributes play, stop, pause, closeAudio, lockQueue, unlockQueue, seek. The main thread waits for each command synchronously, so there can only be one command enabled at a time anyway.
-
Max Kellermann authored
(Ab)use the decoder_command enumeration, which has nearly the same values and the same meaning.
-
Max Kellermann authored
The wavpack decoder plugin implements a hack, and it needs the song URL for that. This API (and the hack) should be revised later, but add that function for now.
-
Max Kellermann authored
dc->seekable is already set by decodeStart().
-
Max Kellermann authored
Since we want to hide mpd internals from the decoder plugins, the plugins should not check dc->state whether they have already called decoder_initialized(). Use a local variable to track that.
-
Max Kellermann authored
Provide access to seeking for the decoder plugins; they have to know where to seek, and they need a way to tell us that seeking has failed.
-
Max Kellermann authored
Some decoder commands are implemented in the decoder plugins, thus they need to have an API call to signal that their current command has been finished. Let them use the new decoder_command_finished() instead of the internal dc_command_finished().
-
Max Kellermann authored
Another big patch which hides internal mpd APIs from decoder plugins: decoder plugins regularly poll dc->command; expose it with a decoder_api.h function.
-
Max Kellermann authored
Since we moved all PCM conversions to decoder_data(), the attribute convState isn't being used anymore by the OutputBuffer code. Move it to struct decoder.
-
Max Kellermann authored
We want to expose the AudioFormat structure to plugins; remove some clutter by moving its declaration to a separate header file.
-
Max Kellermann authored
InputPlugin is the API which is implemented by a decoder plugin. This belongs to the public API/ABI, so move it to decoder_api.h. It will later be renamed to something like "decoder_plugin".
-
Max Kellermann authored
Anonymous code blocks just to declare variables look ugly. Move the variable declarations up and disband the code block.
-
Max Kellermann authored
Similar to previous patch: eliminate one variable by using "break". This also simplifies the code since we can remove one level of indent.
-
Max Kellermann authored
"break" is so much easier than "eof=1; continue;", when "!eof" is the loop condition.
-
Max Kellermann authored
Since we have merged dc->stop, dc->seek into one variable, we don't have to check both conditions at a time; we can replace "!stop && !seek" with "none".
-
Max Kellermann authored
Similar to the previous patch: pass total_time instead of manipulating dc->totalTime directly.
-
Max Kellermann authored
dc->audioFormat is set once by the decoder plugins before invoking decoder_initialized(); hide dc->audioFormat and let the decoder pass an AudioFormat pointer to decoder_initialized().
-
Max Kellermann authored
We are now beginning to remove direct structure accesses from the decoder plugins. decoder_clear() and decoder_flush() mask two very common buffer functions.
-
Max Kellermann authored
Code simplification: since we are not using in-band signalling with the chunk index anymore, we can just return a pointer to the tail chunk instead of the index.
-
Max Kellermann authored
OutputBuffer should be a more generic low-level library, without dependencies to the other headers. This patch adds the field "notify", which is used to signal the player thread. It is passed in the constructor, and removes the need to compile with the decode.h header.
-
Max Kellermann authored
Moved all of the player-waiting code to decoder_data(), to make OutputBuffer more generic.
-
Max Kellermann authored
Avoid some duplicated code in main_notify.c.
-
Max Kellermann authored
After the decoder has been initialized and the audio device has been opened, don't sleep. The decoder plugin won't do anything special nor will it care to wake us up for some reason.
-