Skip to content

M
mpd
Switch branch/tag
  1. 20 Aug, 2006 2 commits
  3. 18 Aug, 2006 4 commits
  5. 15 Aug, 2006 2 commits
  7. 14 Aug, 2006 2 commits
    • Eric Wong's avatar
      Several bugfixes during exit found by valgrind · e5df85db
      Eric Wong authored 
      First, make sure we call finishPlaylist() before
closeMp3Directory() since the latter will free non-SONG_TYPE_URL
songs in playlist, which causes an invalid read when we try to
look for SONG_TYPE_URL songs to free in finishPlaylist.

Secondly, make sure our children have all exited before freeing
the playerData.  If we do not, slowly-delivered signals can
trigger a race condition in the signal handlers of the decode
and player processes which rely on getPlayerData.  To avoid
waitpid-ing too long (or at all), move the freePlayerData() call
farther down in main() (this won't affect anything else)
to give the OS a better chance to deliver signals and finish running
sig handlers for terminated children.

git-svn-id: https://svn.musicpd.org/mpd/trunk@4640 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      e5df85db
    • Eric Wong's avatar
      Revert leaks from r4311, and also the leak fixes as a result of that · 6459b3ee
      Eric Wong authored 
      utf8ToFsCharset() and fsCharsetToUtf8() got very broken in r4311, and
resulted in several commits to fix those leaks.  Unfortunately, not all
of those newly introduced leaks were fixed, nor was the result pretty.

Also, fixed a double-free in lsPlaylists().  This is very hard
to trigger (and therefore exploit) at the moment because we
check printDirectoryInfo() beforehand.

Intended behavior for utf8ToFsCharset() and fsCharsetToUtf8() as
God^H^H^Hshank originally intended is now documented in path.h
to prevent future errors like this.

mpd could still use some good valgrind testing before the 0.12.0
release.

<plug>In addition to reducing heap fragmentation, malloc
reductions from mpd-ke greatly reduces the chance of leaks from
happening due to programming errors.</plug>

git-svn-id: https://svn.musicpd.org/mpd/trunk@4639 09075e82-0dd4-0310-85a5-a0d7c8717e4f
      6459b3ee
  9. 13 Aug, 2006 2 commits
  11. 12 Aug, 2006 2 commits
  13. 11 Aug, 2006 1 commit
  15. 10 Aug, 2006 4 commits
  17. 09 Aug, 2006 2 commits
  19. 08 Aug, 2006 4 commits
  21. 07 Aug, 2006 11 commits
  23. 06 Aug, 2006 3 commits
  25. 05 Aug, 2006 1 commit