When input_stream_read() returns 0, and input_stream_eof() returns
false, an I/O error has occured.  Skip this song.

Don't enlarge the GByteArray when the size limit may overflow in this
operation; check the size limit first.

The local variable "total_len" is superfluous because GByteArray
always knows its size.

The input_stream API sets size to -1 when the size of the resource is
not known.  The modplug decoder checked for size==0, which would be an
empty file.

Don't include utils.h and log.h, they are relics from the past.

Make sure that log messages are decorated correctly.

Don't write CPP if you can write C.

You are allowed to call decoder_read() with decoder==NULL.  It is a
convenience function provided by the decoder API.  Don't manually fall
back to input_stream_read().

Merged casefolding code from two locations into this one library
function.

Changed the function prototypes to get locate_item_list objects
instead of num_items/items.

Instead of passing two parameters around (number of items, array of
items), combine both in a variable size struct.

The declaration initialized only the first element.  Initialize the
whole array with memset() instead.

Use the C99 bool type instead of integer values (1/0 or 0/-1).

Renamed functions and variables.

Fix a typo in one of the previous patches.

Now playlist.c does not contain any protocol specific code anymore.

No CamelCase and no typedefs.

Replaced several wrapper functions from playlist.c, and make command.c
use the queue print functions directly.

To allow code outside playlist.c to access the "queue" object,
provide a function which returns a const pointer.

No typedefs.

Moved the 2 remaining global variables into the playlist struct.

alternative settings must be set before the file
is loaded, otherwise they won't be respected.

Argument cmd of function command_available() is not used if mpd was
configured without sqlite.

In the return value of the "commands" command, don't list the
"sticker" command if no sticker file is configured.

When the playlist was loaded from the state file, the order numbers
were the same as the positions.  In random mode, we need to shuffle
the queue order.  To accomplish that, call setPlaylistRandomStatus()
at the end of readPlaylistState(), and do a fresh shuffle.

song_id_to_position() is only a wrapper for queue_id_to_position().

When MPD is not playing while in random mode, and the client issues
the "clear" command, MPD crashes in stopPlaylist(), or more exactly,
in queue_order_to_position(-1).  Exit from stopPlaylist() if MPD isn't
playing.

Removed unused includes.

Create a new library which saves/loads the queue to/from the state
file.

PlaylistInfo() (notice the capital 'P') sends a stored playlist to the
client.  Move it to a separate library, where all the code which glues
the playlist and the MPD protocol together will live.

Moved protocol printing functions which operate on the queue to
queue_print.c.

The LocateTagItem objects are not modified.

swapSongs() is only a wrapper for queue_swap().

When you delete a song from the playlist which was paused, MPD forgot
that it was paused and started playing the next song.

This patch fixes a regression introduced by commit aa9ffc.

The playlist.c source is currently quite hard to understand.  I have
managed to wrap my head around it, and this patch attempts to explain
it to the next guy.

The function playPlaylistIfPlayerStopped() is only called when the
player thread is stopped.  Converted that runtime check into an
assertion, and remove one indent level.

One of the previous patches removed the "random" mode check from
nextSongInPlaylist(), which caused a shuffle whenever MPD wrapped to
the first song in "repeat" mode.  Re-add that "random" check.

In playPlaylist(), the second "song==-1 && playing" check can never be
reached, because at this point, the function has already returned
(after unpausing).