When the ID3 tag in an AAC file is larger than the current buffer, the
function decoder_buffer_consume() aborts.  By using the new function
decoder_buffer_skip() instead, we can safely skip the ID3 tag.

Include CoreServices/CoreServices.h.

The update job id is positive.  When used in a command list, MPD
prints one job id for each "update" command.

Add a second column of comment signs on some parameters which users
shouldn't usually set, unless they know what they're doing.

This patch made ov_time_total() unusable, and MPD did not know the
duration of songs.

using ov_test_callback with function CALLBACKS_STREAMONLY will cause
scanning to stop after the comment field.  ov_open (and ov_test)
default to CALLBACKS_DEFAULT which scans the file structure causing a
huge slowdown.  The speed improvement is huge: It scanned my files
around 10x faster This procedure has been recommended by monthy (main
vorbis developer) and was said to be safe for scanning files.

MPD checks if every flac (possibly other types as well) file contains
cuesheet on every update, which produces unneeded I/O. My music
collection is on NFS share, so it's quite noticeable. IMHO, it
shouldn't re-read unchanged files, so I wrote simple patch to fix it.

Fix stuttering due to uninitialized variable.

During the pause loop, manually sleep for 500ms if shout_delay()
returns a value greater than that.  Don't exhaust libshout's buffer.

Explicitly make the output thread leave the ao_pause() loop.  This
patch is a workaround, and the "pause" flag is not managed in a
thread-safe way, but that's good enough for now.

dirvec_delete() does not free the object, we have to call
directory_free() afterwards.

The return value of map_directory_child_fs() must be freed.

The function flac_cue_track() first calls FLAC__metadata_object_new(),
then overwrites this pointer with FLAC__metadata_get_cuesheet().  This
allocate two FLAC__StreamMetadata objects, but the first pointer is
lost, and never freed.

When you pass an empty string to directory_update_init(), it was not
freed by update_task().

The FLAC replaygain parser used the "||" operator.  This made the code
stop after the first value which was found.

When one metadata check fails, return quickly.  This removes 2 levels
of indent.

This belongs into "git annotate" or AUTHORS.

When libid3tag is disabled, the libmad decoder plugin is unable to
identify ID3 frames.  If the file starts with an (unidentified) ID3
frame, it assumes that the file is not a valid MP3 song.  This patch
solves this by adding minimal stubs for the ID3 functions.

The function tag_ape_load() retrieves a 32 bit unsigned integer from
the input file, and passes it to g_malloc().  This is dangerous, and
may be used for a denial of service attack on MPD.

Extend the tagLen check after reading it.  Removed the second
(redundant) check after the subtraction.

The expression "tagLen - size > 0" may result in an integer underflow
and a buffer overflow, when "size" is larger than "tagLen".  "size" is
read from the input file, and must not be trusted.  This patch changes
the expression to "tagLen > size", which is a lot safer.

--enable means "enable", not "disable".

If the encoder plugin API is disabled at compile time, don't compile
test/run_encoder.c.

The first patch by Patrick didn't work, because his "#ifdef HAVE_OSX"
line would have required config.h.

Initialize flac_data.tag right after flac_data_init().  This way, the
"goto fail" won't jump to the point where tag_free(NULL) can be
called.