- 02 Nov, 2014 1 commit
-
-
Max Kellermann authored
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround!
-
- 25 Oct, 2014 1 commit
-
-
Max Kellermann authored
Many years ago, FAAD had a serious ABI bug: the NeAACDecInit() prototype in its header declared the "samplerate" parameter to be "unsigned long *", but internally, the function assumed it was "uint32_t *" instead. On 32 bit machines, that was no difference, but on 64 bit, this left one portion of the return value uninitialized; and worse, on big-endian, the wrong word was filled. This bug had to be worked around in MPD (commit 9c4e97a6). A few months later, the bug was fixed in the FAAD CVS in commit 1.117 on file libfaad/decoder.c; the commit message was: "Use public headers internally to prevent duplicate declarations" The commit message was too brief at best; the problem was not duplicate declarations, but a prototype mismatch. No mention of the bug fix in the ChangeLog. The MPD project never learned about this bug fix, and so MPD would always pass a "uin32_t *" dressed up as a "unsigned long *". Nearly 6 years later, it's about time to fix this second ABI problem. Let's kill the workaround!
-
- 29 Jan, 2013 4 commits
-
-
Max Kellermann authored
Drop support for the old faacDec* API.
-
Max Kellermann authored
Fixes build errors on systems without libfaad, when --disable-aac was not specified.
-
Max Kellermann authored
-
Max Kellermann authored
Some of these are not implemented properly and never worked. And the others are not useful; you can easily set environment variables instead.
-
- 28 Jan, 2013 1 commit
-
-
Max Kellermann authored
The underlying library has been obsolete for many years.
-
- 09 Oct, 2011 2 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Don't use MPC_CFLAGS, MPD_LIBS.
-
- 07 Jan, 2011 1 commit
-
-
Max Kellermann authored
Fixes autotools warnings.
-
- 26 May, 2009 1 commit
-
-
Max Kellermann authored
Append $FAAD_LIBS to $LIBS when detecting libmp4ff. $FAAD_LIBS may contain an important -L flag.
-
- 29 Apr, 2009 1 commit
-
-
Avuton Olrich authored
-
- 06 Mar, 2009 1 commit
-
-
Avuton Olrich authored
-