- 01 Sep, 2017 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
- 04 Jun, 2017 1 commit
-
-
Max Kellermann authored
-
- 03 Jun, 2017 1 commit
-
-
Max Kellermann authored
This commit is similar to 788e3b31, and removes more "pure" attributes which were placed on functions that could throw exceptions, which is illegal according to clang's understanding of the attribute (but not according to GCC's). GitHub issue #58 was most likely about StorageDirectoryReader::GetInfo() and Storage::GetInfo(), which still had "pure" attributes. Closes #58
-
- 08 May, 2017 2 commits
-
-
Max Kellermann authored
The "pure" and "const" attributes are not so well-defined, and a recent clang version implements an optimization which pushes the definition's boundary beyond what I believed it was. clang now assumes that functions declared "pure" cannot throw exceptions, even if they lack the "noexcept" specification. When compiled with this new clang version, MPD will crash randomly if an exception happens to get thrown by such as "pure" function (https://github.com/MusicPlayerDaemon/MPD/issues/41). This commit removes all such misplaced "pure" and "const" attributes, closing #41.
-
Max Kellermann authored
This eliminates some overhead, because the compiler doesn't need to consider these functions throwing.
-
- 06 Apr, 2017 1 commit
-
-
Max Kellermann authored
An ino_t is usually a 64 bit integer, and some file systems (such as Linux's kernel NFS client) really uses the upper 32 bit. This can lead to false positives in the directory loop detection in FindAncestorLoop(). Increasing these two attributes (in StorageFileInfo and Directory) to 64 bit adds little overhead, but makes the check a lot safer.
-
- 08 Jan, 2017 1 commit
-
-
Max Kellermann authored
-
- 03 Jan, 2017 3 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
-
- 28 Dec, 2016 1 commit
-
-
Max Kellermann authored
-
- 02 Nov, 2016 1 commit
-
-
Max Kellermann authored
-
- 27 Oct, 2016 6 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
-
Max Kellermann authored
If an error has already been set by f.directory->storage->GetInfo(), don't set it again.
-
Max Kellermann authored
It was used in a wrong way, which did not deal with errors consistently. And if that's wrong, there is no need for FindStorage() at all - let's remove it and the confusion around it.
-
Max Kellermann authored
-
Max Kellermann authored
-
- 16 Sep, 2016 1 commit
-
-
Max Kellermann authored
-
- 05 Sep, 2016 1 commit
-
-
Max Kellermann authored
-
- 23 Aug, 2016 1 commit
-
-
Max Kellermann authored
-
- 12 Apr, 2016 1 commit
-
-
Max Kellermann authored
-
- 01 Mar, 2016 1 commit
-
-
Max Kellermann authored
-
- 26 Feb, 2016 1 commit
-
-
Max Kellermann authored
-
- 29 Dec, 2015 1 commit
-
-
Max Kellermann authored
-
- 06 Nov, 2015 1 commit
-
-
Max Kellermann authored
-
- 26 Jun, 2015 1 commit
-
-
Max Kellermann authored
default_value defaults to nullptr.
-
- 29 May, 2015 1 commit
-
-
Thomas Guillem authored
The Connect method can be called between Schedule and lock. In that case, when locked, the state is already set to CONNECTING of READY and the condition won't be signaled anymore.
-
- 03 Mar, 2015 1 commit
-
-
Max Kellermann authored
-
- 28 Feb, 2015 2 commits
-
-
Max Kellermann authored
Replaces StatFile(), with a portable data object.
-
Max Kellermann authored
-
- 21 Jan, 2015 1 commit
-
-
Max Kellermann authored
-
- 01 Jan, 2015 1 commit
-
-
Max Kellermann authored
-
- 26 Dec, 2014 1 commit
-
-
Max Kellermann authored
Return false on error, not nullptr.
-
- 14 Dec, 2014 1 commit
-
-
Max Kellermann authored
Fixes bogus assertion failure.
-
- 28 Nov, 2014 1 commit
-
-
Max Kellermann authored
-
- 09 Oct, 2014 2 commits
-
-
Max Kellermann authored
Share the NFS connection with the NFS input plugin.
-
Max Kellermann authored
-