Fixes use-after-free because the temporary goes out of scope.

"DEFAULT" is a bad name - all it says is that it's the default value,
but it doesn't say what it means.  The name NOTICE mimics the syslog
level.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/846

This fixes compatibility with Plex DLNA.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/851

Closes https://github.com/MusicPlayerDaemon/MPD/issues/841

Fixes the "Unrecognized URI" error with the udisks storage plugin,
which is caused by the kludge in UdisksStorage::MapUTF8().

The ones in std have overloads for const char/char.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

The `db->close()` call was a `nullptr` dereference because the `db`
variable had already been moved.

Closes https://github.com/MusicPlayerDaemon/MPD/issues/839

Reduces unstripped size. stripped size is the same.

Also took the time to remove using std::placeholders.
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Found with modernize-use-nodiscard
Signed-off-by: Rosen Penev <rosenp@gmail.com>

Eliminates one strlen() call.

Eliminates lots of overhead.

Split the string into path segments with StringView::Split().  This
prepares to eliminate all allocations from the method.

Use std::string_view to avoid modifying the string for the temporary
null terminators.