- 05 Jul, 2009 2 commits
-
-
Max Kellermann authored
-
Max Kellermann authored
Renamed functions.
-
- 13 Mar, 2009 1 commit
-
-
Avuton Olrich authored
This updates the copyright header to all be the same, which is pretty much an update of where to mail request for a copy of the GPL and the years of the MPD project. This also puts all committers under 'The Music Player Project' umbrella. These entries should go individually in the AUTHORS file, for consistancy.
-
- 02 Mar, 2009 1 commit
-
-
Max Kellermann authored
Do error reporting with GLib's GError library in this library, too.
-
- 28 Feb, 2009 1 commit
-
-
Max Kellermann authored
Remember the modification time of each directory. This is important for archives (which are virtual directories right now), but may also be useful for an automatic update mechanism.
-
- 27 Feb, 2009 1 commit
-
-
Max Kellermann authored
Moved some of them to to directory_save.c, and others to database.c.
-
- 04 Jan, 2009 1 commit
-
-
Max Kellermann authored
directory_is_root() is cheaper than isRootDirectory(directory_get_path()).
-
- 03 Jan, 2009 1 commit
-
-
Max Kellermann authored
-
- 29 Dec, 2008 1 commit
-
-
Max Kellermann authored
Only include headers which are really needed. os_compat.h aimed to make MPD easily portable, but was never actually made portable.
-
- 28 Dec, 2008 1 commit
-
-
Max Kellermann authored
Replaced myFgets() with fgets() + g_strchomp().
-
- 28 Oct, 2008 1 commit
-
-
Max Kellermann authored
Remove duplicated code from MPD.
-
- 20 Oct, 2008 1 commit
-
-
Max Kellermann authored
GLib's g_path_get_basename() is much more reliable than mpd_basename(). The latter could be tricked into an assertion failure.
-
- 09 Oct, 2008 4 commits
-
-
Max Kellermann authored
Don't use db_get_directory() and traverse the full path with every directory being loaded. Just see if the current parent contains the entry. Everything else would be invalid anyway..
-
Max Kellermann authored
A manipulated database could trigger an assertion failure, because the parent didn't match. Do a proper check if the new directory is within the parent's. This uses FATAL() to bail out, so MPD still dies, but it doesn't crash.
-
Max Kellermann authored
No idea why it was created in directory.h, but it should be in dirvec.h.
-
Max Kellermann authored
Remove clutter from directory.c. Everything which saves or loads to/from the hard disk goes to directory_save.c, and code which sends directory information to the client is moved into directory_print.c.
-
- 08 Oct, 2008 11 commits
-
-
Max Kellermann authored
For the root directory, let's set path to an empty string. This saves a few checks.
-
Max Kellermann authored
CamelCase is ugly, rename the functions.
-
Max Kellermann authored
Yet another CamelCase removal patch.
-
Max Kellermann authored
Taming the directory.c monster, part II: move the database management stuff to database. directory.c should only contain code which works on directory objects.
-
Max Kellermann authored
The function isRootDirectory() is tiny and can be converted to an inline function. Don't allow name==NULL.
-
Max Kellermann authored
CamelCase is ugly... rename all functions.
-
Max Kellermann authored
Again, a data type which can be forward-declared.
-
Max Kellermann authored
The struct can be forward-declared by other headers, which relaxes the header dependencies.
-
Max Kellermann authored
exploreDirectory() duplicates some code in updateDirectory(). Merge both functions, and use directory_is_empty() to determine whether update or explore mode should be used.
-
Max Kellermann authored
directory_is_empty() is a tiny inline function which determine if a directory has any child objects (sub directories or songs).
-
Max Kellermann authored
The source directory.c mixes several libraries: directory object management, database management and database update, resulting in a 1000+ line monster. Move the whole database update code to update.c.
-
- 07 Oct, 2008 5 commits
-
-
Eric Wong authored
oops :x
-
Eric Wong authored
This makes the update code thread-safe and doesn't penalize the playlist code by complicating it with complicated and error-prone locks (and the associated overhead, not everybody has a thread-implementation as good as NPTL). The update task blocks during the delete; but the update task is a slow task anyways so we can block w/o people caring too much. This was also our only freeSong call site, so remove that function. Note that deleting entire directories is not fully thread-safe, yet; as their traversals are not yet locked.
-
Eric Wong authored
Get rid of songvec_write so we can enforce proper locking
-
Eric Wong authored
Being consistent with most UNIX functions...
-
Eric Wong authored
song objects cannot exist without a path or URL
-
- 06 Oct, 2008 5 commits
-
-
Eric Wong authored
We already know if a song is a URL or not based on whether it has parentDir defined or not. Hopefully one day in the future we can drop HTTP support from MPD entirely when an HTTP filesystem comes along and we can access streams via open(2).
-
Eric Wong authored
Reduce the number of allocations we make, so there's less pressure on the allocator and less overhead to keep track of the allocations in.
-
Eric Wong authored
Instead of allocating a new one, just reuse an existing one if one is found when rereading the DB. This is a small makes the previous commit work on subdirectories of the root music directory. [1] "song: better handling of existing songs when rereading DB"
-
Eric Wong authored
Now the "update" command can be issued multiple times regardless of whether the client is in list mode or not. We serialize the update tasks to prevent updates from trampling over each other and will spawn another update task once the current one is finished updating and reaped. Right now we cap the queue size to 32 which is probably enough (I bet most people usually run update with no argument anyways); but we can make it grow/shrink dynamically if needed. There'll still be a hard-coded limit to prevent DoS attacks, though.
-
Eric Wong authored
Instead of relying on the shortname, just pass the song pointer to prevent redundant lookups during deletes.
-
- 29 Sep, 2008 3 commits