• Max Kellermann's avatar
    output/osx: improve sample rate selection · 691b6a23
    Max Kellermann authored
    The formula in osx_output_score_sample_rate() to detect multiples of
    the source sample rate was broken: when given a 44.1 kHz input file,
    it preferred 16 kHz over 48 kHz, because its `frac_portion(16)=0.75`
    is smaller than `frac_portion(48)=0.91`.
    
    That formula, introduced by commit 40a1ebee, looks completely
    wrong.  It doesn't do what the code comment pretends it does.
    
    Instead of using that `frac_portion` to calculate a score, this patch
    adds to the score only if `frac_portion` is nearly `0` or `1`.  This
    means that the factor is nearly integer.
    
    Closes https://github.com/MusicPlayerDaemon/MPD/issues/904
    691b6a23
Name
Last commit
Last update
..
httpd Loading commit data...
sles Loading commit data...
AlsaOutputPlugin.cxx Loading commit data...
AlsaOutputPlugin.hxx Loading commit data...
AoOutputPlugin.cxx Loading commit data...
AoOutputPlugin.hxx Loading commit data...
FifoOutputPlugin.cxx Loading commit data...
FifoOutputPlugin.hxx Loading commit data...
HaikuOutputPlugin.cxx Loading commit data...
HaikuOutputPlugin.hxx Loading commit data...
JackOutputPlugin.cxx Loading commit data...
JackOutputPlugin.hxx Loading commit data...
NullOutputPlugin.cxx Loading commit data...
NullOutputPlugin.hxx Loading commit data...
OSXOutputPlugin.cxx Loading commit data...
OSXOutputPlugin.hxx Loading commit data...
OpenALOutputPlugin.cxx Loading commit data...
OpenALOutputPlugin.hxx Loading commit data...
OssOutputPlugin.cxx Loading commit data...
OssOutputPlugin.hxx Loading commit data...
PipeOutputPlugin.cxx Loading commit data...
PipeOutputPlugin.hxx Loading commit data...
PulseOutputPlugin.cxx Loading commit data...
PulseOutputPlugin.hxx Loading commit data...
RecorderOutputPlugin.cxx Loading commit data...
RecorderOutputPlugin.hxx Loading commit data...
ShoutOutputPlugin.cxx Loading commit data...
ShoutOutputPlugin.hxx Loading commit data...
SndioOutputPlugin.cxx Loading commit data...
SndioOutputPlugin.hxx Loading commit data...
SolarisOutputPlugin.cxx Loading commit data...
SolarisOutputPlugin.hxx Loading commit data...
WinmmOutputPlugin.cxx Loading commit data...
WinmmOutputPlugin.hxx Loading commit data...
meson.build Loading commit data...